Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[O11y][Hadoop] Lens migration for visualizations to kibana version 8.3.0 #5503

Closed
wants to merge 4 commits into from
Closed

[O11y][Hadoop] Lens migration for visualizations to kibana version 8.3.0 #5503

wants to merge 4 commits into from

Conversation

harnish-elastic
Copy link
Contributor

  • Enhancement

What does this PR do?

  • Migrate visualizations to lens for Hadoop integration package

  • Statistics for Hadoop Lens migration:

Hadoop dashboards Before Migration   After Migration  
  Lens Visualization Lens Visualization
[Metrics Hadoop] Applications 0 7 7 0
[Metrics Hadoop] Cluster overview 0 8 8 0
[Metrics Hadoop] Data nodes 6 3 9 0
[Metrics Hadoop] Node Manager 0 3 3 0
  6 21 27 0

Checklist

  • I have added an entry to my package's changelog.yml file.
  • I have verified that panels are populated with data.
  • I have verified that panels are not distorted after being migrated to lens.
  • I have updated screenshots of dashboard.
  • I have verified that data count are matching and panel aggregations are same as before.

Author's checklist

  • Migrated panels should be removed from visualization folder.
  • Migrated visualizations are populating in current Kibana version 8.3.0 itself.

Related issues

@harnish-elastic harnish-elastic mentioned this pull request Mar 10, 2023
Closed
8 tasks
@kush-elastic kush-elastic added enhancement New feature or request v8.3.0 Team:Service-Integrations Label for the Service Integrations team labels Mar 10, 2023
@elasticmachine
Copy link

elasticmachine commented Mar 10, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-21T09:17:02.870+0000

  • Duration: 20 min 15 sec

Test stats 🧪

Test Results
Failed 0
Passed 31
Skipped 0
Total 31

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@kush-elastic kush-elastic marked this pull request as ready for review March 10, 2023 12:17
@kush-elastic kush-elastic requested a review from a team as a code owner March 10, 2023 12:17
@elasticmachine
Copy link

elasticmachine commented Mar 10, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (5/5) 💚
Files 100.0% (9/9) 💚
Classes 100.0% (9/9) 💚
Methods 100.0% (47/47) 💚 8.824
Lines 99.18% (605/610) 👎 -0.82
Conditionals 100.0% (0/0) 💚

kush-elastic
kush-elastic approved these changes Mar 13, 2023
View reviewed changes
Copy link
Collaborator

@kush-elastic kush-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agithomas
Copy link
Contributor

Can you consider breaking down the PR to smaller one ?

@harnish-elastic
Copy link
Contributor Author

harnish-elastic commented Mar 21, 2023 •
edited
Loading

Can you consider breaking down the PR to smaller one ?

Sure @agithomas, breaking down the PR into the following PRs:

  • Application (0.5.0)
  • Cluster (0.6.0)
  • Data Node and Node Manager (0.7.0)

Let me know if it looks good to you! Also do we need to bump up the version for every PR?

@harnish-elastic
Merge branch 'main' of https://github.com/harnish-elastic/integrations …
d98e445 
…into lens_migration-hadoop-8.1.0

Conflicts:
	packages/hadoop/changelog.yml
	packages/hadoop/manifest.yml
@harnish-elastic
Merge branch 'main' of https://github.com/harnish-elastic/integrations …
fbfb550 
…into lens_migration-hadoop-8.1.0
@agithomas
Copy link
Contributor

Let me know if it looks good to you! Also do we need to bump up the version for every PR?

looks good. Version change is optional, no harm in making an increment also.

@harnish-elastic
Copy link
Contributor Author

@agithomas As breakdown this PR is getting difficult, created 3 other PRs dashboard wise. For that reason we are declining this PR. Let me know if you have any issues.

#5605
#5606
#5607

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kush-elastic kush-elastic kush-elastic approved these changes

@lalit-satapathy lalit-satapathy Awaiting requested review from lalit-satapathy

@agithomas agithomas Awaiting requested review from agithomas

Assignees

@harnish-elastic harnish-elastic

Labels
enhancement New feature or request Team:Service-Integrations Label for the Service Integrations team v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@harnish-elastic @elasticmachine @agithomas @kush-elastic