[EuiSelectable] EuiSelectable's onChange prop not passing a full event back on React v16 #6026
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
@jeramysoucy alerted us that the 2nd
event
arg on EuiSelectable'sonChange
callback (added in #5926) is not working in Kibana. This is due to Kibana being on React v16 and EUI being on React v17 (see https://reactjs.org/docs/legacy-event-pooling.html).I tested a built version of this branch against local Kibana and can confirm event types, shiftKey, nativeEvent data etc. are now correctly coming through:
Checklist
yarn build-pack
Kibana test