[EuiMark] Fix screen-reader only CSS causing scroll issues in Chrome #5921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Match CSS (+ comments) to existing Sass with comments - Match exported name to other mixins (e.g., text utilities)
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5921/ |
thompsongl
approved these changes
May 23, 2022
There was a problem hiding this comment.
LGTM! Confirmed the scrollbar fix.
Linking #5846 as I'll need to reconcile these changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
EuiMark's pseudo
::before/::afterelements had some custom screen reader only CSS that wasn't the actual CSS in our.euiScreenReaderOnlyutility. The CSS we're using in our existing mixin has been battle-tested and accounts for many cross-browser shenanigans (see #5130, #5152), and we shouldn't be deviating from it.This PR fixes the Emotion
euiScreenReaderOnlymixin to match our Sass mixin w/ comments and then updates EuiMark to use said mixin.Before / After:
Checklist