[EuiMark] Fix screen-reader only CSS causing scroll issues in Chrome #5921
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
EuiMark's pseudo
::before/::after
elements had some custom screen reader only CSS that wasn't the actual CSS in our.euiScreenReaderOnly
utility. The CSS we're using in our existing mixin has been battle-tested and accounts for many cross-browser shenanigans (see #5130, #5152), and we shouldn't be deviating from it.This PR fixes the Emotion
euiScreenReaderOnly
mixin to match our Sass mixin w/ comments and then updates EuiMark to use said mixin.Before / After:
Checklist