Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiDataGrid] improve height calculation #5447

Merged
merged 8 commits into from
Dec 7, 2021
Merged

[EuiDataGrid] improve height calculation #5447

merged 8 commits into from
Dec 7, 2021

Commits on Dec 6, 2021

  1. Calculate the grid's height based on all known values

    @chandlerprall
    chandlerprall committed Dec 6, 2021
    Configuration menu
    Copy the full SHA
    efc9082 View commit details
    Browse the repository at this point in the history

  2. Add cypress test to verify switching from default single row height t… 

    …o auto fit will expand the grid
    @chandlerprall
    chandlerprall committed Dec 6, 2021
    Configuration menu
    Copy the full SHA
    b949221 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2021

  1. remove comment

    @chandlerprall
    chandlerprall committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    eee6d88 View commit details
    Browse the repository at this point in the history

  2. Compute the grid's unconstrained height when a row's height changes

    @chandlerprall
    chandlerprall committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    47a2113 View commit details
    Browse the repository at this point in the history

  3. Simplify setRenderPass logic

    @cee-chen @chandlerprall
    cee-chen authored and chandlerprall committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    cc80120 View commit details
    Browse the repository at this point in the history

  4. Added useForceRender hook, refactored data grid row height updating t… 

    …o use the new hook
    @chandlerprall
    chandlerprall committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    fb8f1f2 View commit details
    Browse the repository at this point in the history

  5. Created a hook to better organize and document how the unconstrained … 

    …height is calculated
    @chandlerprall
    chandlerprall committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    4d55a90 View commit details
    Browse the repository at this point in the history

  6. Update src/services/hooks/useForceRender.ts 

    Co-authored-by: Constance <constancecchen@users.noreply.github.com>
    @chandlerprall
    chandlerprall and Constance authored Dec 7, 2021
    Configuration menu
    Copy the full SHA
    6335717 View commit details
    Browse the repository at this point in the history