Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiDataGrid] Add rowHeightSwitcher logic + API change #5372

Commits on Nov 11, 2021

  1. Configuration menu
    Copy the full SHA
    916c1c7 View commit details
    Browse the repository at this point in the history
  2. Refactor out nested object helper

    - so that both the columnSelector and displaySelector can use it
    cee-chen committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    79c878d View commit details
    Browse the repository at this point in the history
  3. Update displaySelector with conditional density/row height options

    + update docs:
      - reorder UI to match toolbar layout
      - fix legends
    
    + add unit tests (& improve some existing unit tests)
    cee-chen committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    58fe94f View commit details
    Browse the repository at this point in the history
  4. Add rowHeightsOptions controls to popover

    NYI: conditional lineCount controls
    
    + unit tests
    cee-chen committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    37aecd6 View commit details
    Browse the repository at this point in the history
  5. Add conditional lineCount row and logic

    + fix cell height to dynamically on lineCount change
    cee-chen committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    129b2bb View commit details
    Browse the repository at this point in the history
  6. Fix styles not applying correctly for rowHeightsOptions that have und…

    …efined heights but defined rowHeightsOptions objects
    
    e.g. - empty objs, or lineHeight set but nothing else
    
    + simplify this.props
    cee-chen committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    742051d View commit details
    Browse the repository at this point in the history
  7. Fix multiline content not top-aligning correctly when in single/undef…

    …ined mode
    
    - Multiline content includes items with `<br>`/`<p>` tags etc that end up incorrectly vertically centered to their increased height
    cee-chen committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    be59b08 View commit details
    Browse the repository at this point in the history
  8. Fix single/undefined row heights to account for passed lineHeight API…

    … + density
    
    - by giving it the same setRowHeight logic as line counts with a single line
    
    + rename recalculateLineCountHeight for clarity now that it's no longer being used for just lineCount
    cee-chen committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    75e933a View commit details
    Browse the repository at this point in the history
  9. Add changelog entry

    cee-chen committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    39aa176 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2021

  1. [PR feedback] Increase default lineCount to 2

    - to make the difference more obvious when switching between single and custom
    cee-chen committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    8580dc8 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2021

  1. Merge branch 'feat/datagrid/toolbar-reorg-and-row-height-switcher' in…

    …to datagrid-row-height-control
    cee-chen committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    0a4eae8 View commit details
    Browse the repository at this point in the history
  2. Fix changelog

    cee-chen committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    7e34537 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d31a66d View commit details
    Browse the repository at this point in the history
  4. Tweak various height alignments on compressed grid settings

    - expand buttons on single lines should now be more vertically aligned
    
    - The manual button/checkbox changes for control columns is somewhat required for auto height to not be dramatically different for single lines
    cee-chen committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    670dc2c View commit details
    Browse the repository at this point in the history
  5. Fix expand action button background color mismatch for auto/lineCount…

    … rows
    
    - when hovering over rows
    - on striped rows
    
    - Not caused by this PR, but this was really annoying me, haha
    cee-chen committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    c3f237d View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2021

  1. PR feedback: convert cell actions CSS selectors to mixin

    - Slightly less grody to look at in-code, and allows us to provide more comments for context
    
    The more I look at __expandButton the more I dislike the naming also but it would involve too many changes right now to rename button->actions, so I added a TODO
    cee-chen committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    4dac79e View commit details
    Browse the repository at this point in the history
  2. Fix sasslint issues

    cee-chen committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    cb51f97 View commit details
    Browse the repository at this point in the history
  3. PR feedback: Change line count number to EuiRange

    + Remove ability to set negative or zero numbers, which causes the grid to flip out
    cee-chen committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    b70aa3d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    52d70e3 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    3891366 View commit details
    Browse the repository at this point in the history
  6. Remove unused unit tests

    - This should have been done in 79c878d, but I missed it
    cee-chen committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    cab4a06 View commit details
    Browse the repository at this point in the history
  7. [PR feedback] Intelligently disable toolbar control if all nested opt…

    …ions are disabled
    
    Notes:
    - Strongly recommend turning off whitespace changes to reduce indentation noise
    - This could have been done at the `data_grid_toolbar` level and could be a microperf optimization to do so, but since this is a relatively unlikely edge case in any case I don't think it's worth the overoptimization when this approach is relatively straightforward to implement
    cee-chen committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    571be25 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2021

  1. Merge branch 'feat/datagrid/toolbar-reorg-and-row-height-switcher' in…

    …to datagrid-row-height-control
    cee-chen committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    9348b1d View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2021

  1. Configuration menu
    Copy the full SHA
    3dd2d3f View commit details
    Browse the repository at this point in the history
  2. PR changelog feedback

    Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
    Constance and cchaos authored Nov 23, 2021
    Configuration menu
    Copy the full SHA
    0ab5aac View commit details
    Browse the repository at this point in the history
  3. Update grid density to also intelligently detect initial state

    + not set a button state if custom fontSize/cellPadding don't match our defined density states
    cee-chen committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    f226ad7 View commit details
    Browse the repository at this point in the history
  4. Merge branch 'feat/datagrid/toolbar-reorg-and-row-height-switcher' in…

    …to datagrid-row-height-control
    cee-chen committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    be0db10 View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2021

  1. [PR feedback] Improve typing to avoid any usage

    + improve unit tests to cover undefined nested object key case
    cee-chen committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    fc9f65c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4250a73 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    fc4105c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0b9ca21 View commit details
    Browse the repository at this point in the history