-
Notifications
You must be signed in to change notification settings - Fork 839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiDataGrid] Add rowHeightSwitcher logic + API change #5372
[EuiDataGrid] Add rowHeightSwitcher logic + API change #5372
Commits on Nov 11, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 916c1c7 - Browse repository at this point
Copy the full SHA 916c1c7View commit details -
Refactor out nested object helper
- so that both the columnSelector and displaySelector can use it
Configuration menu - View commit details
-
Copy full SHA for 79c878d - Browse repository at this point
Copy the full SHA 79c878dView commit details -
Update displaySelector with conditional density/row height options
+ update docs: - reorder UI to match toolbar layout - fix legends + add unit tests (& improve some existing unit tests)
Configuration menu - View commit details
-
Copy full SHA for 58fe94f - Browse repository at this point
Copy the full SHA 58fe94fView commit details -
Add rowHeightsOptions controls to popover
NYI: conditional lineCount controls + unit tests
Configuration menu - View commit details
-
Copy full SHA for 37aecd6 - Browse repository at this point
Copy the full SHA 37aecd6View commit details -
Add conditional lineCount row and logic
+ fix cell height to dynamically on lineCount change
Configuration menu - View commit details
-
Copy full SHA for 129b2bb - Browse repository at this point
Copy the full SHA 129b2bbView commit details -
Fix styles not applying correctly for rowHeightsOptions that have und…
…efined heights but defined rowHeightsOptions objects e.g. - empty objs, or lineHeight set but nothing else + simplify this.props
Configuration menu - View commit details
-
Copy full SHA for 742051d - Browse repository at this point
Copy the full SHA 742051dView commit details -
Fix multiline content not top-aligning correctly when in single/undef…
…ined mode - Multiline content includes items with `<br>`/`<p>` tags etc that end up incorrectly vertically centered to their increased height
Configuration menu - View commit details
-
Copy full SHA for be59b08 - Browse repository at this point
Copy the full SHA be59b08View commit details -
Fix single/undefined row heights to account for passed lineHeight API…
… + density - by giving it the same setRowHeight logic as line counts with a single line + rename recalculateLineCountHeight for clarity now that it's no longer being used for just lineCount
Configuration menu - View commit details
-
Copy full SHA for 75e933a - Browse repository at this point
Copy the full SHA 75e933aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 39aa176 - Browse repository at this point
Copy the full SHA 39aa176View commit details
Commits on Nov 16, 2021
-
[PR feedback] Increase default lineCount to 2
- to make the difference more obvious when switching between single and custom
Configuration menu - View commit details
-
Copy full SHA for 8580dc8 - Browse repository at this point
Copy the full SHA 8580dc8View commit details
Commits on Nov 17, 2021
-
Merge branch 'feat/datagrid/toolbar-reorg-and-row-height-switcher' in…
…to datagrid-row-height-control
Configuration menu - View commit details
-
Copy full SHA for 0a4eae8 - Browse repository at this point
Copy the full SHA 0a4eae8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7e34537 - Browse repository at this point
Copy the full SHA 7e34537View commit details -
Configuration menu - View commit details
-
Copy full SHA for d31a66d - Browse repository at this point
Copy the full SHA d31a66dView commit details -
Tweak various height alignments on compressed grid settings
- expand buttons on single lines should now be more vertically aligned - The manual button/checkbox changes for control columns is somewhat required for auto height to not be dramatically different for single lines
Configuration menu - View commit details
-
Copy full SHA for 670dc2c - Browse repository at this point
Copy the full SHA 670dc2cView commit details -
Fix expand action button background color mismatch for auto/lineCount…
… rows - when hovering over rows - on striped rows - Not caused by this PR, but this was really annoying me, haha
Configuration menu - View commit details
-
Copy full SHA for c3f237d - Browse repository at this point
Copy the full SHA c3f237dView commit details
Commits on Nov 18, 2021
-
PR feedback: convert cell actions CSS selectors to mixin
- Slightly less grody to look at in-code, and allows us to provide more comments for context The more I look at __expandButton the more I dislike the naming also but it would involve too many changes right now to rename button->actions, so I added a TODO
Configuration menu - View commit details
-
Copy full SHA for 4dac79e - Browse repository at this point
Copy the full SHA 4dac79eView commit details -
Configuration menu - View commit details
-
Copy full SHA for cb51f97 - Browse repository at this point
Copy the full SHA cb51f97View commit details -
PR feedback: Change line count number to EuiRange
+ Remove ability to set negative or zero numbers, which causes the grid to flip out
Configuration menu - View commit details
-
Copy full SHA for b70aa3d - Browse repository at this point
Copy the full SHA b70aa3dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 52d70e3 - Browse repository at this point
Copy the full SHA 52d70e3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3891366 - Browse repository at this point
Copy the full SHA 3891366View commit details -
- This should have been done in 79c878d, but I missed it
Configuration menu - View commit details
-
Copy full SHA for cab4a06 - Browse repository at this point
Copy the full SHA cab4a06View commit details -
[PR feedback] Intelligently disable toolbar control if all nested opt…
…ions are disabled Notes: - Strongly recommend turning off whitespace changes to reduce indentation noise - This could have been done at the `data_grid_toolbar` level and could be a microperf optimization to do so, but since this is a relatively unlikely edge case in any case I don't think it's worth the overoptimization when this approach is relatively straightforward to implement
Configuration menu - View commit details
-
Copy full SHA for 571be25 - Browse repository at this point
Copy the full SHA 571be25View commit details
Commits on Nov 19, 2021
-
Merge branch 'feat/datagrid/toolbar-reorg-and-row-height-switcher' in…
…to datagrid-row-height-control
Configuration menu - View commit details
-
Copy full SHA for 9348b1d - Browse repository at this point
Copy the full SHA 9348b1dView commit details
Commits on Nov 23, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 3dd2d3f - Browse repository at this point
Copy the full SHA 3dd2d3fView commit details -
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 0ab5aac - Browse repository at this point
Copy the full SHA 0ab5aacView commit details -
Update grid density to also intelligently detect initial state
+ not set a button state if custom fontSize/cellPadding don't match our defined density states
Configuration menu - View commit details
-
Copy full SHA for f226ad7 - Browse repository at this point
Copy the full SHA f226ad7View commit details -
Merge branch 'feat/datagrid/toolbar-reorg-and-row-height-switcher' in…
…to datagrid-row-height-control
Configuration menu - View commit details
-
Copy full SHA for be0db10 - Browse repository at this point
Copy the full SHA be0db10View commit details
Commits on Nov 24, 2021
-
[PR feedback] Improve typing to avoid any usage
+ improve unit tests to cover undefined nested object key case
Configuration menu - View commit details
-
Copy full SHA for fc9f65c - Browse repository at this point
Copy the full SHA fc9f65cView commit details -
[PR feedback] Document recommendation for disabling row height switch…
…er when using `rowHeights` @see elastic#5411
Configuration menu - View commit details
-
Copy full SHA for 4250a73 - Browse repository at this point
Copy the full SHA 4250a73View commit details -
Configuration menu - View commit details
-
Copy full SHA for fc4105c - Browse repository at this point
Copy the full SHA fc4105cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0b9ca21 - Browse repository at this point
Copy the full SHA 0b9ca21View commit details