-
Notifications
You must be signed in to change notification settings - Fork 839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update references to the default branch name #5344
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 🎉
Preview documentation changes for this PR: https://eui.elastic.co/pr_5344/ |
@@ -5,7 +5,7 @@ | |||
description: Jobs to run on EUI pull requests | |||
project-type: multijob | |||
concurrent: true | |||
node: master | |||
node: main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❔ Maybe this isn't doing what I think? I didn't expect this job to work prior to the name change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This references the CI node, not a git branch. Will revert.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
@@ -2,7 +2,7 @@ name: "Changelog required" | |||
on: | |||
pull_request: | |||
types: [opened, synchronize, reopened, ready_for_review, labeled, unlabeled] | |||
branches: [ master ] | |||
branches: [ main ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ As expected, the changelog check did not run due to this change
Co-authored-by: Constance <constancecchen@users.noreply.github.com>
Preview documentation changes for this PR: https://eui.elastic.co/pr_5344/ |
Summary
🔜 This will not merge until after the default branch has been renamed
main
Supports #5322 by updating all references to the default branch name in code and documentation.
### Checklist