Update references to the default branch name #5344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
cee-chen
reviewed
Nov 2, 2021
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5344/ |
thompsongl
commented
Nov 2, 2021
| @@ -5,7 +5,7 @@ | |||
| description: Jobs to run on EUI pull requests | |||
| project-type: multijob | |||
| concurrent: true | |||
| node: master | |||
| node: main | |||
There was a problem hiding this comment.
❔ Maybe this isn't doing what I think? I didn't expect this job to work prior to the name change
There was a problem hiding this comment.
This references the CI node, not a git branch. Will revert.
thompsongl
commented
Nov 2, 2021
| @@ -2,7 +2,7 @@ name: "Changelog required" | |||
| on: | |||
| pull_request: | |||
| types: [opened, synchronize, reopened, ready_for_review, labeled, unlabeled] | |||
| branches: [ master ] | |||
| branches: [ main ] | |||
There was a problem hiding this comment.
✅ As expected, the changelog check did not run due to this change
Co-authored-by: Constance <constancecchen@users.noreply.github.com>
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5344/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
🔜 This will not merge until after the default branch has been renamed
mainSupports #5322 by updating all references to the default branch name in code and documentation.
### Checklist