-
Notifications
You must be signed in to change notification settings - Fork 840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add useMemo util for htmlIdGenerator + update EuiDataGrid's IDs to not change on every rerender #5133
Merged
Commits on Sep 2, 2021
-
Create a htmlIdGenerator utility hook
- that creates a memoized ID, preventing the issue of re-randomized IDs on every component change
Configuration menu - View commit details
-
Copy full SHA for c5bd90b - Browse repository at this point
Copy the full SHA c5bd90bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6e51759 - Browse repository at this point
Copy the full SHA 6e51759View commit details -
Configuration menu - View commit details
-
Copy full SHA for f5c3c39 - Browse repository at this point
Copy the full SHA f5c3c39View commit details -
Add API for overriding generated IDs with custom IDs (primarily from …
…props) + update EuiCollapsibleNav as an example of real-world usage
Configuration menu - View commit details
-
Copy full SHA for 5921ac7 - Browse repository at this point
Copy the full SHA 5921ac7View commit details
Commits on Sep 3, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 1009e4c - Browse repository at this point
Copy the full SHA 1009e4cView commit details
Commits on Sep 7, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 04a1832 - Browse repository at this point
Copy the full SHA 04a1832View commit details -
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 0a2a20a - Browse repository at this point
Copy the full SHA 0a2a20aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0bafa10 - Browse repository at this point
Copy the full SHA 0bafa10View commit details
Commits on Sep 8, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 414f0be - Browse repository at this point
Copy the full SHA 414f0beView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0e7325a - Browse repository at this point
Copy the full SHA 0e7325aView commit details
Commits on Sep 9, 2021
-
Document useGeneratedHtmlId options in a props table
+ include more documentation text
Configuration menu - View commit details
-
Copy full SHA for 61f6ab8 - Browse repository at this point
Copy the full SHA 61f6ab8View commit details -
Configuration menu - View commit details
-
Copy full SHA for e5049fa - Browse repository at this point
Copy the full SHA e5049faView commit details -
- update comment from ref to memo - Skip EuiFlexGroup
Configuration menu - View commit details
-
Copy full SHA for 1317d94 - Browse repository at this point
Copy the full SHA 1317d94View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a5b167 - Browse repository at this point
Copy the full SHA 5a5b167View commit details -
Configuration menu - View commit details
-
Copy full SHA for 09142a8 - Browse repository at this point
Copy the full SHA 09142a8View commit details -
Fix CodeSandbox demos + standardize naming/casing
- Changed exports from named exports to default in order for demos to work in CodeSandbox - Added `htmlIdGenerator` namespacing for clarity to all prefix/suffix sections - Fixed casing on `bothPrefixSuffix.js` to snake_casing (per rest of codebase) - Fixed casing of all source & snippet vars to camelCasing - Fixed `sufix` typo
Configuration menu - View commit details
-
Copy full SHA for bb86659 - Browse repository at this point
Copy the full SHA bb86659View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.