Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add useMemo util for htmlIdGenerator + update EuiDataGrid's IDs to not change on every rerender #5133

Merged
merged 16 commits into from
Sep 9, 2021
Merged

Add useMemo util for htmlIdGenerator + update EuiDataGrid's IDs to not change on every rerender #5133

merged 16 commits into from
Sep 9, 2021

Commits on Sep 2, 2021

  1. Create a htmlIdGenerator utility hook 

    - that creates a memoized ID, preventing the issue of re-randomized IDs on every component change
    @cee-chen
    cee-chen committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    c5bd90b View commit details
    Browse the repository at this point in the history

  2. Update test env mocks with new helper

    @cee-chen
    cee-chen committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    6e51759 View commit details
    Browse the repository at this point in the history

  3. Update EuiDataGrid with static IDs

    @cee-chen
    cee-chen committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    f5c3c39 View commit details
    Browse the repository at this point in the history

  4. Add API for overriding generated IDs with custom IDs (primarily from … 

    …props)

+ update EuiCollapsibleNav as an example of real-world usage
    @cee-chen
    cee-chen committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    5921ac7 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2021

  1. Add changelog entry and documentation

    @cee-chen
    cee-chen committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    1009e4c View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2021

  1. Merge branch 'master' into use-htmlidgenerator

    @cee-chen
    cee-chen committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    04a1832 View commit details
    Browse the repository at this point in the history

  2. PR documentation feedback 

    Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
    @cchaos @cee-chen
    2 people authored and cee-chen committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    0a2a20a View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into use-htmlidgenerator

    @cee-chen
    cee-chen committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    0bafa10 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2021

  1. Merge branch 'master' into use-htmlidgenerator

    @cee-chen
    cee-chen committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    414f0be View commit details
    Browse the repository at this point in the history

  2. [PR feedback] Change idFromProps to conditionalId

    @cee-chen
    cee-chen committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    0e7325a View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2021

  1. Document useGeneratedHtmlId options in a props table 

    + include more documentation text
    @cee-chen
    cee-chen committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    61f6ab8 View commit details
    Browse the repository at this point in the history

  2. More clearly document distinction between htmlIdGenerator and useGene… 

    …ratedHtmlId
    @cee-chen
    cee-chen committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    e5049fa View commit details
    Browse the repository at this point in the history

  3. Address PR feedback 

    - update comment from ref to memo
- Skip EuiFlexGroup
    @cee-chen
    cee-chen committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    1317d94 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into use-htmlidgenerator

    @cee-chen
    cee-chen committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    5a5b167 View commit details
    Browse the repository at this point in the history

  5. Spotted a typo

    @cee-chen
    cee-chen committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    09142a8 View commit details
    Browse the repository at this point in the history

  6. Fix CodeSandbox demos + standardize naming/casing 

    - Changed exports from named exports to default in order for demos to work in CodeSandbox

- Added `htmlIdGenerator` namespacing for clarity to all prefix/suffix sections

- Fixed casing on `bothPrefixSuffix.js` to snake_casing (per rest of codebase)

- Fixed casing of all source & snippet vars to camelCasing

- Fixed `sufix` typo
    @cee-chen
    cee-chen committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    bb86659 View commit details
    Browse the repository at this point in the history