Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix screenreader text in DG sort dropdown #5084

Merged
merged 4 commits into from
Aug 25, 2021
Merged

Fix screenreader text in DG sort dropdown #5084

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
459bf06
Fix screenreader text in DG sort dropdown
snide Aug 25, 2021
fd05a86
cl
snide Aug 25, 2021
314a286
Update src/components/datagrid/column_sorting_draggable.tsx
snide Aug 25, 2021
40ad5a0
Merge branch 'master' into dg/screenreader
snide Aug 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
**Bug fixes**

- Fixed location of default value of `EuiToolTip`'s `display` prop ([#5066](https://github.com/elastic/eui/pull/5066))
- Fixed instance of `EuiScreenReader` text being exposed in `EuiDataGrid` sorting menu ([#5084](https://github.com/elastic/eui/pull/5084))
- Fixed default value of `EuiPagination`'s `activePage` to target first page ([#5053](https://github.com/elastic/eui/pull/5053))

**Theme: Amsterdam**
Expand Down
16 changes: 9 additions & 7 deletions src/components/datagrid/column_sorting_draggable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,13 +70,15 @@ export const EuiDataGridColumnSortingDraggable: FunctionComponent<EuiDataGridCol
}`}
>
<EuiScreenReaderOnly>
<EuiI18n
token="euiColumnSortingDraggable.activeSortLabel"
default="{display} is sorting this data grid"
values={{ display }}
>
{(activeSortLabel: string) => <p>{activeSortLabel}</p>}
</EuiI18n>
<p>
<EuiI18n
token="euiColumnSortingDraggable.activeSortLabel"
default="{display} is sorting this data grid"
values={{ display }}
>
{(activeSortLabel: string) => activeSortLabel}
</EuiI18n>
</p>
</EuiScreenReaderOnly>
<EuiFlexGroup
gutterSize="xs"
Expand Down