Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript tooling, pt. 1 #4695

Closed
wants to merge 1 commit into from
Closed

Conversation

thompsongl
Copy link
Contributor

Summary

Starting a chip-away-at-it set of PRs to fully (finally) complete the migration from JS to TS, with an emphasis on build tooling.
Scope is not entirely clear right now, this is 1 of n.

In this one:

  • Delete last .js files in src/
  • Start the transition away from packages/ code in the bundle
  • Resolve some types errors that arose from the move

Thinking about:

  • Probably a breaking change to remove Packages from index.ts
  • Perhaps a better way to handle react-datepicker (new index.d.ts in packages/)

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
  • Props have proper autodocs and playground toggles
  • Added documentation
  • Checked Code Sandbox works for the any docs examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4695/

@thompsongl
Copy link
Contributor Author

Closing in favor of a better scoped #5034. Feel free to re-open if this still works as a starting point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants