Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Amsterdam] Use rounded corners and bolder titles for EuiCallout #3557

Merged
merged 9 commits into from
Jun 8, 2020
Merged
Show file tree
Hide file tree
Changes from 7 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@
- Improved `EuiPagination`, `EuiDataGrid`, `EuiBasicTable` and `EuiInMemoryTable` accessibility, causing `EuiPaginationButton` to require a new prop `pageIndex` ([#3294](https://github.com/elastic/eui/pull/3294))
- Replaced all usages of [`KeyboardEvent.keyCode`](https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/keyCode) (deprecated) with [`KeyboardEvent.key`](https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/key). From `@elastic/eui/lib/services`, `keyCodes` has been replaced with `keys`, as has `cascadingMenuKeyCodes`->`cascadingMenuKeys`, and `comboBoxKeyCodes`->`comboBoxKeys`. The implementation of all of those exports (as well as `accessibleClickKeys`) all now use `KeyboardEvent.key` values. ([#3517](https://github.com/elastic/eui/pull/3517))

**Theme: Amsterdam**

- Removed left border from `EuiCallout` and added border radius and increased font weight on titles. ([#3557](https://github.com/elastic/eui/pull/3557/))
cchaos marked this conversation as resolved.
Show resolved Hide resolved


## [`24.1.0`](https://github.com/elastic/eui/tree/v24.1.0)

Expand Down
1 change: 1 addition & 0 deletions src/components/flyout/_flyout_body.scss
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@

.euiFlyoutBody__banner .euiCallOut {
border: none; // Remove border from callout when it is a flyout banner
border-radius: 0;
cchaos marked this conversation as resolved.
Show resolved Hide resolved
padding-left: $euiSizeL; // Align callout's content with flyout's title
padding-right: $euiSizeL; // Align callout's content with flyout's title
}
Expand Down
8 changes: 8 additions & 0 deletions src/themes/eui-amsterdam/overrides/_call_out.scss
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
.euiCallOut {
border-radius: $euiBorderRadius;
border-left: none;

.euiCallOutHeader__title {
font-weight: $euiFontWeightMedium;
}
}
cchaos marked this conversation as resolved.
Show resolved Hide resolved
2 changes: 1 addition & 1 deletion src/themes/eui-amsterdam/overrides/_flyout.scss
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
// The clip path ensures only the left side of the shadow is exposed.
.euiFlyout {
clip-path: polygon(-10% 0, 100% 0, 100% 100%, -10% 100%);
}
}
cchaos marked this conversation as resolved.
Show resolved Hide resolved
3 changes: 2 additions & 1 deletion src/themes/eui-amsterdam/overrides/_index.scss
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
@import 'button';
@import 'button_empty';
@import 'button_group';
@import 'call_out';
@import 'flyout';
@import 'header';
@import 'image';
@import 'modal';
@import 'overlay_mask';
@import 'popover';
@import 'text';
@import 'text';
cchaos marked this conversation as resolved.
Show resolved Hide resolved