Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiTab] Icons on selected tabs don't inherit the primary color as the text does #6935

Closed
prgueza opened this issue Jul 12, 2023 · 2 comments · Fixed by #6938
Closed

[EuiTab] Icons on selected tabs don't inherit the primary color as the text does #6935

prgueza opened this issue Jul 12, 2023 · 2 comments · Fixed by #6938
Assignees
Labels

Comments

@prgueza
Copy link

prgueza commented Jul 12, 2023

Describe the bug

Icons on selected tabs don't inherit the primary color as the text and the bottom border (box-shadow) do. Not 100% sure if this is a bug or the expected behaviour, but it feels a bit unnatural.

image

Environment and versions

  • EUI version: 84.0.0
  • React version: 17
  • Kibana version (if applicable):
  • Browser: Google Chrome (Version 114.0.5735.198 (Official Build) (arm64))
  • Operating System: Mac OS Ventura 3.14

To Reproduce

Steps to reproduce the behavior:

  1. Set up a tabs component where the tabs use icons
  2. Click on any tab with an icon
  3. Check that the icon color doesn't change accordingly

Expected behavior

The icon on selected tabs uses the primary color as the text and the bottom border (box-shadow) do.

image

Minimum reproducible sandbox

https://codesandbox.io/s/gr57c3?file=/demo.js

@prgueza prgueza added bug ⚠️ needs validation For bugs that need confirmation as to whether they're reproducible labels Jul 12, 2023
@cee-chen
Copy link
Member

It looks like icons did inherit the color in EUI v60 (https://eui.elastic.co/v60.0.0/#/navigation/tabs#tabbed-content), so this did regress at some point, likely due to an Emotion conversion. Thanks for the report @prgueza, I'll look into a fix!

@cee-chen cee-chen removed the ⚠️ needs validation For bugs that need confirmation as to whether they're reproducible label Jul 12, 2023
@cee-chen cee-chen self-assigned this Jul 12, 2023
@prgueza
Copy link
Author

prgueza commented Jul 12, 2023

I was happy opening a pull request myself, but if you have the time to look in to it, all yours by all means! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants