-
Notifications
You must be signed in to change notification settings - Fork 829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SearchBar] Export common search_bar/query
types
#6218
Comments
@thompsongl @chandlerprall Can you weigh in on whether we'd consider exporting the types @PhaedrusTheGreek listed in the above example at the top level of To be perfectly honest, my first instinct is to say no. My worry is that their names are incredibly generic vs EUI specific, and might end up causing annoying namespace conflicts (see: RTL shenanigans). Additionally, the listed types are still obtainable by diving into the specific component / files, so it's not like they're not available for complex use cases - whereas the majority of consumers will not need them at the top level 🤷 |
I agree with the concerns about exporting the existing types/interfaces as they are. That whole query/ast class could do with a documentation & types pass, which would better inform what could be exported to support implementations. |
We won't be addressing this at this time. |
It is possible to supply a custom
options.fieldValuesToQuery
toQuery.toESQuery
, however much of the types required to work with that function are not exported from@elastic/eui
:Specifically,
The text was updated successfully, but these errors were encountered: