Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navbar theme="dark" has not background (ghost) while in full dark theme has #6203

Closed
tomitank opened this issue Sep 5, 2022 · 4 comments
Closed

Comments

@tomitank
Copy link

tomitank commented Sep 5, 2022

I think the old ghost background was great for popover menü button.
But the point is that now the code is not consistent. There is still a background in full dark mode.

@miukimiu
Copy link
Contributor

miukimiu commented Sep 5, 2022

Hi @tomitank,

Can you share some screenshots of the issue you're facing?

@tomitank
Copy link
Author

tomitank commented Sep 6, 2022

Hi @miukimiu
you can testing theme popover on https://eui.elastic.co. Switch you between dark and light.

@miukimiu
Copy link
Contributor

miukimiu commented Sep 6, 2022

@tomitank if you refering to EuiButton wiht the color ghost inside a EuiHeader please read the following comment explaining why is not working:

#5989 (comment)

We're currently converting all EUI components to Emotion. In the meanwhile some issues like these will emerge.
As you can see from the following list, #5685 , the EuiHeader has not yet been converted to Emotion. So it uses a dark baground that doesn't have enough contrast with the button.

@tomitank
Copy link
Author

tomitank commented Sep 7, 2022

@miukimiu
thanks your answer. I'll wait for the fix because it's not very good.

@tomitank tomitank closed this as completed Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants