Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an optional 'tootipText' property to EuiListGroupItem so that the text of the tooltip can be overridden #6114

Closed
qpointsystems opened this issue Aug 8, 2022 · 1 comment · Fixed by #6186
Labels
feature request good first issue help wanted The EUI team is looking for community members to pick up and implement this issue

Comments

@qpointsystems
Copy link

qpointsystems commented Aug 8, 2022

EuiListGroup components can be used in various contexts. One common usage is in the context of a Menu where the EuiListGroup's listItems property contains a list of menu items (EuiListGroupItem instances) represented under a Group(er).

The EuiListGroupItem is used to represent an individual Menu item/action. EuiListGroupItem currently has a required 'label' property which forms the text of the Menu Item displayed on the UI. Users have the optional ability for a given EuiListGroupItem of setting the showToolTip property to true. Setting showToolTip to {true} has the effect of displaying a Tooltip next to the menu item.

Current Eui behavior as of 62.1.0 has the text that is displayed in the EuiListGroupItem's ToolTip set to the value of the 'label' property. This is fine as a default value. But this behavior has limited utility from a UIX pov. Re-displaying in a ToolTip the label that is in most cases Already being displayed to the user seems redundant. True, there is a situation where the EuiListGroupItem's value text is 'hidden', and only the Icon is displayed. In that case, the Tooltip is available to indicate to the user the Action or behavior of the EuiListGroupItem's Icon.

Adding a 'toolTipLabel' or 'toolTipText' will allow users of the EuiListGroup and EuiListGroupItem components to provide contextual help/guidance beyond simply repeating the typically already visible EuiListGroupItem.label.

@cchaos cchaos added assign:anyone good first issue help wanted The EUI team is looking for community members to pick up and implement this issue labels Aug 8, 2022
@spzala19
Copy link
Contributor

Thanks for the details. Let me work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request good first issue help wanted The EUI team is looking for community members to pick up and implement this issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants