Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

euiScreenReaderOnly dissapeared from theme css in 60.2.0 #6037

Closed
wanjas opened this issue Jul 8, 2022 · 2 comments
Closed

euiScreenReaderOnly dissapeared from theme css in 60.2.0 #6037

wanjas opened this issue Jul 8, 2022 · 2 comments

Comments

@wanjas
Copy link

wanjas commented Jul 8, 2022

Hello,

Seems like at least .euiScreenReaderOnly disappeared from
@elastic/eui/dist/eui_theme_light.css and @elastic/eui/dist/eui_theme_dark.css
in 60.2.0 (was present in 59.1.0)

It seems like a bug.

@thompsongl
Copy link
Contributor

thompsongl commented Jul 8, 2022

Hi @wanjas

This is not a bug, but one of the steps toward EUI moving from Sass and compiled CSS to CSS-in-JS via Emotion.

The .euiScreenReaderOnly class will still work when the application is using EuiProvider, which is a requirement for application styling. You can see the class continuing to work in the docs under the Styles helpers heading.

We will continue to support utility classes in CSS-in-JS with EuiProvider (with potential caveats) moving forward. As we continue to convert components, though, @elastic/eui/dist/eui_theme_light.css and @elastic/eui/dist/eui_theme_dark.css will continue to shrink until they are removed entirely.

@wanjas
Copy link
Author

wanjas commented Jul 9, 2022

@thompsongl Oh, thank you! I've somehow missed this transition to EuiProvider.

Problem solved

@wanjas wanjas closed this as completed Jul 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants