Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiColorPalettePicker][COGNITION]: The sr-only accessible label is not announcing what color palette is selected #5367

Closed
Tracked by #5265
1Copenut opened this issue Nov 9, 2021 · 0 comments · Fixed by #5364

Comments

@1Copenut
Copy link
Contributor

1Copenut commented Nov 9, 2021

Description:
I discovered the EuiColorPalettePicker accessible label is looking for a text element that does not exist to populate the SR-only accessible label. This should be adjusted to read out the palette's descriptive name.

Guidance:
https://www.w3.org/WAI/WCAG21/Understanding/info-and-relationships


Screen Shot 2021-11-09 at 12 46 26 PM

1Copenut added a commit that referenced this issue Nov 17, 2021
…description (#5364)

* Adding generated IDs to create accessible label and description
* Generated class attributes for aria-labelledby and aria-describedby
* Updated snapshot tests
* Adding CHANGELOG entry to main
* Refactoring props for cleaner implementation
* Removed `screenReaderId` from parent, passed directly to child component
* Added screen reader text to the Color Palette Picker button
* Updated snapshot tests
* Removing unnecessary prop from EuiColorPalettePicker
* Adding screen reader only titles for Color Palette Picker
* Refactored to add `aria-hidden` to color bars
* Added screen reader only text titles
* Fixes an axe-core issue with buttons needing discernible text in SuperSelect
* Added issue #5367 to CHANGELOG
* Removing extra ternary logic in Color Palette Picker
* Editing CHANGELOG message for mis-spelling.
* Adding inline comment to explain a11y intent
* Refactoring to use spread operator to pass title prop
* Adding conditional checks to avoid empty SR-only spans.
* Revising describedby helper text after screen reader testing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant