Fix screenreader text in DG sort dropdown (#5084)

DG dropdown had a problem with i18n text and the close from screen reader.
elastic · Aug 25, 2021 · f1f395f · f1f395f
1 parent fa14cf4
commit f1f395f
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 7 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -8,6 +8,7 @@
 **Bug fixes**
 
 - Fixed location of default value of `EuiToolTip`'s `display` prop ([#5066](https://github.com/elastic/eui/pull/5066))
+- Fixed instance of  `EuiScreenReader` text being exposed in `EuiDataGrid` sorting menu ([#5084](https://github.com/elastic/eui/pull/5084))
 - Fixed default value of `EuiPagination`'s `activePage` to target first page ([#5053](https://github.com/elastic/eui/pull/5053))
 
 **Theme: Amsterdam**

diff --git a/src/components/datagrid/column_sorting_draggable.tsx b/src/components/datagrid/column_sorting_draggable.tsx
@@ -70,13 +70,15 @@ export const EuiDataGridColumnSortingDraggable: FunctionComponent<EuiDataGridCol
           }`}
         >
           <EuiScreenReaderOnly>
-            <EuiI18n
-              token="euiColumnSortingDraggable.activeSortLabel"
-              default="{display} is sorting this data grid"
-              values={{ display }}
-            >
-              {(activeSortLabel: string) => <p>{activeSortLabel}</p>}
-            </EuiI18n>
+            <p>
+              <EuiI18n
+                token="euiColumnSortingDraggable.activeSortLabel"
+                default="{display} is sorting this data grid"
+                values={{ display }}
+              >
+                {(activeSortLabel: string) => activeSortLabel}
+              </EuiI18n>
+            </p>
           </EuiScreenReaderOnly>
           <EuiFlexGroup
             gutterSize="xs"