Skip to content

Commit

Permalink
[Amsterdam] Use rounded corners and bolder titles for EuiCallout (#3557)
Browse files Browse the repository at this point in the history
* round corners + bold titles

* no rounded corners on Flyout banner

* update changelog

* semi bold titles

* use medium font weight instead

* update changelog

* Apply suggestions from code review

* Fix my bad edit of CL

Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
  • Loading branch information
Henry Harding and cchaos authored Jun 8, 2020
1 parent 1bc2b29 commit ccb3e09
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 0 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,10 @@
- Improved `EuiPagination`, `EuiDataGrid`, `EuiBasicTable` and `EuiInMemoryTable` accessibility, causing `EuiPaginationButton` to require a new prop `pageIndex` ([#3294](https://github.com/elastic/eui/pull/3294))
- Replaced all usages of [`KeyboardEvent.keyCode`](https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/keyCode) (deprecated) with [`KeyboardEvent.key`](https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/key). From `@elastic/eui/lib/services`, `keyCodes` has been replaced with `keys`, as has `cascadingMenuKeyCodes`->`cascadingMenuKeys`, and `comboBoxKeyCodes`->`comboBoxKeys`. The implementation of all of those exports (as well as `accessibleClickKeys`) all now use `KeyboardEvent.key` values. ([#3517](https://github.com/elastic/eui/pull/3517))

**Theme: Amsterdam**

- Updated `EuiCallout` by removing left border, adding border radius and increasing font weight on titles ([#3557](https://github.com/elastic/eui/pull/3557/))


## [`24.1.0`](https://github.com/elastic/eui/tree/v24.1.0)

Expand Down
1 change: 1 addition & 0 deletions src/components/flyout/_flyout_body.scss
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@

.euiFlyoutBody__banner .euiCallOut {
border: none; // Remove border from callout when it is a flyout banner
border-radius: 0; // Ensures no border-radius in all themes
padding-left: $euiSizeL; // Align callout's content with flyout's title
padding-right: $euiSizeL; // Align callout's content with flyout's title
}
Expand Down
8 changes: 8 additions & 0 deletions src/themes/eui-amsterdam/overrides/_call_out.scss
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
.euiCallOut {
border-radius: $euiBorderRadius;
border-left: none;

.euiCallOutHeader__title {
font-weight: $euiFontWeightMedium;
}
}
1 change: 1 addition & 0 deletions src/themes/eui-amsterdam/overrides/_index.scss
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
@import 'button';
@import 'button_empty';
@import 'button_group';
@import 'call_out';
@import 'flyout';
@import 'header';
@import 'image';
Expand Down

0 comments on commit ccb3e09

Please sign in to comment.