-
Notifications
You must be signed in to change notification settings - Fork 839
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Single UI polish] Set dynamic minRowHeight based on grid density
Previously rows had a static 34px min height which looked super out of place next to lineCount (which correctly sets row height based on density). This especially looked bad after the align-items baseline change (which was required to get multi-line elements working however). This basically updates the single/undefined state to match how lineCount work and to dynamically update the row height based on density. It also increase default row height for normal density to 36px - assuming Amsterdam theme as default. I was previously using '34' as a shorthand for 'default height' in many unit tests, so I've done a general find&replace where it made sense I also removed the default row height fallback for rowHeightUtils - getCalculatedHeight will pick the defaultHeight (which is minRowHeight) in any case since it will be larger than 0, so there's no need for this to be a realistic number
- Loading branch information
Showing
11 changed files
with
132 additions
and
78 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.