Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to define default for track-total-hits from cluster or index settings #63689

Closed
jguay opened this issue Oct 14, 2020 · 4 comments
Closed
Labels
>enhancement :Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team

Comments

@jguay
Copy link
Contributor

jguay commented Oct 14, 2020

From 7.0, track-total-hits defaults to 10000 and must be set at request level to show more accurate total hit
It would be useful to be able to set default value for cluster instead of via individual request. For example if an application always require accurate count, a change is required for all searches defined and in some cases having a cluster setting would allow easier upgrade by setting the setting at cluster level

@jguay jguay added >enhancement needs:triage Requires assignment of a team area label labels Oct 14, 2020
@jguay jguay changed the title Ability to define default for track-total-hits-10000-default Ability to define default for track-total-hits from cluster or index settings Oct 14, 2020
@jguay jguay added the :Search/Search Search-related issues that do not fall into other categories label Oct 14, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/Search)

@elasticmachine elasticmachine added the Team:Search Meta label for search team label Oct 14, 2020
@yurafff
Copy link

yurafff commented Oct 15, 2020

Is this task still relevant? I want to help with the implementation of this feature

@gwbrown gwbrown removed the needs:triage Requires assignment of a team area label label Oct 22, 2020
@damienalexandre
Copy link
Contributor

This has been discussed already at #46779 and the conclusion was to not add a setting, and things could have been done more smoothly.

I'm currently migrating an application from 5.x to 7.x and not having this kind of global setting will prevent me from having queries compatible with both 5.x and 7.x (which would have been helpful for a no downtime migration).

@jimczi
Copy link
Contributor

jimczi commented Dec 18, 2020

Following the recommendation discussed in #46779 I am closing this issue. We'll not provide an index setting for this parameter that can be changed on a per-request basis.

@jimczi jimczi closed this as completed Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>enhancement :Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team
Projects
None yet
Development

No branches or pull requests

6 participants