Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for Python 3.5 #148

Closed
sethmlarson opened this issue Mar 24, 2020 · 1 comment
Closed

Drop support for Python 3.5 #148

sethmlarson opened this issue Mar 24, 2020 · 1 comment

Comments

@sethmlarson
Copy link
Contributor

We're aiming to follow Pandas supported Python version list so we should follow pandas by dropping 3.5

This would look like:

  • Updating python_requires in setup.py
  • Removing compat.py and replacing usage of PY36 properly
  • Running pyupgrade on the codebase, investigate the changes
  • Updating our test matrix

While we're at it we should potentially run black on the codebase since pyupgrade will almost certainly modify at least one thing per file.
@sethmlarson
Copy link
Contributor Author

Done in #150

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sethmlarson