[BUG] useSniffing parameter is actually dontUseSniffing

[kammerjaeger]

ECS integration/library project(s) (e.g. Elastic.CommonSchema.Serilog):
Elastic.Serilog.Sinks

ECS .NET assembly version (e.g. 1.4.2):
8.6.1

Description of the problem, including expected versus actual behavior:
The parameter is the opposite of what its name is, that is quite confusing.
See:

ecs-dotnet/src/Elastic.Serilog.Sinks/ElasticsearchSinkExtensions.cs

Line 81 in eac06c3

var transportConfig = useSniffing ? TransportHelper.Static(nodes) : TransportHelper.Sniffing(nodes);

Possible solution: 0f0f894

[Mpdreamz]

This took embarrassingly long to address, thank you for raising this @kammerjaeger.

This should be fixed once #445 lands.

[kammerjaeger]

Maybe add a comment in the release note that this may break existing configurations when deployed and in use with the previous logic.

[Mpdreamz]

I changed the default to false so there is no breaking change, thanks for calling that out.

[kammerjaeger]

Good catch that is a problem, too. But I was more talking about the people like me who actively set it have to inverse the setting with the new release.