Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cluster license cannot be updated by ECK if it has already expired #6274

Closed
pebrc opened this issue Jan 4, 2023 · 0 comments · Fixed by #6278
Closed

Cluster license cannot be updated by ECK if it has already expired #6274

pebrc opened this issue Jan 4, 2023 · 0 comments · Fixed by #6278
Assignees
Labels
>bug Something isn't working

Comments

@pebrc
Copy link
Collaborator

pebrc commented Jan 4, 2023

Related #5796

With the changes from above mentioned PR it is no longer possible to update the cluster license if the currently installed license has already expired because the reachability criterion relies on a successful health observation:

https://github.com/elastic/cloud-on-k8s/blob/2.5/pkg/controller/elasticsearch/driver/driver.go#L243

We need to distinguish the two criteria (service has endpoints and health API responds).

However it seems with expired license health observations are no longer possible as the health API is blocked in the degraded state Elasticsearch enters into when the license expires.

One potential fix for this issue is therefore only apply the first criteria (service has endpoints) when deciding whether to try the license API call or not.

Workarounds:

@pebrc pebrc added the >bug Something isn't working label Jan 4, 2023
@pebrc pebrc self-assigned this Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant