Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Elasticsearch client should enrich errors returned with context information about the request #4918

Closed
pebrc opened this issue Oct 1, 2021 · 0 comments · Fixed by #4922
Closed

Elasticsearch client should enrich errors returned with context information about the request #4918

pebrc opened this issue Oct 1, 2021 · 0 comments · Fixed by #4922
Assignees
@barkbay
Labels
>enhancement Enhancement of existing functionality good first issue Good for newcomers

Comments

@pebrc
Copy link
Collaborator

pebrc commented Oct 1, 2021

It is currently very hard to find out what specific request to Elasticsearch caused an error. Especially if there is no additional debug logging around that request and the error bubbles up all the way to the top most error handler in controller-runtime.

We should at least decorate each error create in the Elasticsearch client code with the original request.
@pebrc pebrc added >enhancement Enhancement of existing functionality good first issue Good for newcomers labels Oct 1, 2021
@barkbay barkbay self-assigned this Oct 4, 2021
@barkbay barkbay mentioned this issue Oct 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@barkbay barkbay

Labels
>enhancement Enhancement of existing functionality good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor Elasticsearch HTTP error handling barkbay/cloud-on-k8s
2 participants
@pebrc @barkbay