Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement contextPropagationOnly config var, tweak disableSend behaviour #2393

Closed
trentm opened this issue Oct 26, 2021 · 0 comments · Fixed by #2396
Closed

implement contextPropagationOnly config var, tweak disableSend behaviour #2393

trentm opened this issue Oct 26, 2021 · 0 comments · Fixed by #2396
Assignees
@trentm
Labels
agent-nodejs Make available for APM Agents project planning.
Milestone
8.0

Comments

@trentm
Copy link
Member

trentm commented Oct 26, 2021

Spec PR: elastic/apm#461

Earlier I implemented disableSend to do what the spec eventually settled on calling context_propagation_only -- i.e. I implemented an earlier version of the spec quickly for elastic/kibana#97934 to use.

The intent is to have:

  • disableSend to just skip sending events to APM server, but otherwise do all regular processing. The use case for this is simulating APM agent usage, say for CI.
  • contextPropagationOnly to do what disableSend is currently doing: skipping sending events to APM server and minimizing work.

At the time of writing, that Kibana issue has not yet merged. As well, the docs for the currently released disableSend don't mention the "minimizing work". Therefore, currently I think it would be fine to change the current disableSend behaviour to no longer minimize work without that being a breaking change. The steps would be:

  • Merge and release an impl of contextPropagationOnly and disableSend as intended.
  • Get the Kibana PR above to change to use contextPropagationOnly.

Alternatively, if Kibana ships using disableSend, then we might have to wait on changing disableSend behaviour until the next major.
@trentm trentm added this to the 8.0 milestone Oct 26, 2021
@trentm trentm self-assigned this Oct 26, 2021
@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Oct 26, 2021
@trentm trentm mentioned this issue Oct 27, 2021
Merged
6 tasks
trentm added a commit that referenced this issue Nov 2, 2021
@trentm
feat: impl contextPropagationOnly config var; change disableSend beha…
ba570ba 
…viour (#2396)

Implement contextPropagationOnly per spec (it does what disableSend
did before this change). Change disableSend to just disable comms
with APM server, but otherwise *not* attempt to reduce work.
https://github.com/elastic/apm/blob/master/specs/agents/transport.md#context_propagation_only-configuration

Closes: #2393
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trentm trentm

Labels
agent-nodejs Make available for APM Agents project planning.
Projects
None yet
Milestone
8.0
Development

Successfully merging a pull request may close this issue.

feat: impl contextPropagationOnly config var; change disableSend behaviour elastic/apm-agent-nodejs
1 participant
@trentm