-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add high contrast schemes #1110
Conversation
84ef508
to
5fd8642
Compare
The high contrast mode (hc mode) should now be finished. Here are some more thoughts I have:
And also let me know if I missed something. |
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I missed the notification for your push+comment!
I like what you've done! I tested it in light hc and dark hc and basically everything looks very high contrast and good (well, for a high contrast mode). The play/pause button you asked about seems fine to me. I only have a few things I noticed while testing:
- The cut buttons could use an outline on hover? Their hover effect is very subtle. Well ok, there is the tooltip, which isn't very subtle... maybe that's enough. You decide.
- In the trimming step: the contrast/difference between the timeline that's already played and that is about to play is fairly low. I think it would be possible to make the "about to be played" part a bit brighter (in light hc) and still have enough contrast to the background.
- The "Discard" button has high contrast, but the red is not really coming through. So these users would miss out on the warning color. Maybe it's worth it making the button background red? Then it would be super heavy of course. Just an idea, no opinion I think 🤷
- In dark hc, the floating boxes for shortcuts and info have the same background than the main part and no border. Thus its not really clear where the box starts and ends. I would probably just add a bright border? Alternatively the overlay should be white-semi-transparent instead of black-semi-transparent.
- In dark hc, the links in the "info" box are not colored. But they could easily be colored like in light hc right?
And a few code comments, but these should all be quick to fix, and most of them are the same "kind of comment" just in multiple places.
This commit only lays the foundation and makes the header usable. There is still more work required, checking all of Studio for good UX.
The previous one was a very very bright green tone. I changed it to a very bright version of our normal accent color. It would be weird to suddenly have green where otherwise Studio only uses blue. Now I understand that with green you can get brighter while maintaining high saturation, better than with blue. But I think this blue is bright enough. Further, the only reason I noticed this is that I, as someone with strong Protonopia did not even see that that was green at all. I assume the accent color was just white. I think by making it a tiny bit less bright and using blue, the chance of that happening to other people is a lot less.
d7ae6b0
to
25f018d
Compare
Since Nadine will be absent for the coming two weeks, I quickly fixed most of my comments (and rebased). Some of the less opinionated comments I didn't change. It's still fine like this. Since I only added very little extra stuff and already reviewed otherwise, I will merge. |
Draft as there is still more work to be done. @narickmann will probably take it from here.