Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Capturing "Display & Camera" does not work in Safari (macOS) #934

Closed
JulianKniephoff opened this issue May 30, 2022 · 3 comments · Fixed by #1127
Closed

Capturing "Display & Camera" does not work in Safari (macOS) #934

JulianKniephoff opened this issue May 30, 2022 · 3 comments · Fixed by #1127
Assignees
@owi92
Labels
platform:desktop This impacts a desktop version type:bug Something isn't working

Comments

@JulianKniephoff
Copy link
Member

When pressing the "Display & Capture"-button in Safari on macOS I'm not asked for permission to share my screen. Instead, I see the following error.

image

Camera capture works just fine, as does capturing only the screen (using the "Display" button in the first step).

The following error is logged to the console on the screen seen in the screenshot:

[Error] Error: InvalidAccessError: getDisplayMedia must be called from a user gesture handler.
	(anonymous function) (2.859294be.chunk.js:2:305924)
	(anonymous function) (4.58adb615.chunk.js:1:12044)
	asyncFunctionResume
	(anonymous function)
	promiseReactionJobWithoutPromise

(Everything tested on https://studio.opencast.org.)
@JulianKniephoff JulianKniephoff added type:bug Something isn't working B-safari platform:desktop This impacts a desktop version labels May 30, 2022
@LukasKalbertodt LukasKalbertodt mentioned this issue May 30, 2022
Closed
@lkiesow
Copy link
Contributor

lkiesow commented Oct 17, 2022

Safari does now seem to support getDisplayMedia.

@LukasKalbertodt
Copy link
Member

@JulianKniephoff Can you test whether it works now, especially with the redesign?

@JulianKniephoff
Copy link
Member Author

image

owi92 added a commit to owi92/opencast-studio that referenced this issue Sep 27, 2023
@owi92
Fix concurrent screen/display capturing in safari
46f9f28 
Safari needs a "user gesture" (i.e. a button click)
to call `getDisplayMedia`. Calling the user capture
first would prevent the display capture to register
the triggering button click, so this switches the
ordering (for safari only).
Closes elan-ev#934.
@owi92 owi92 mentioned this issue Sep 27, 2023
Merged
owi92 added a commit to owi92/opencast-studio that referenced this issue Sep 27, 2023
@owi92
Fix concurrent screen/display capturing in safari
2c6dd38 
Safari needs a "user gesture" (i.e. a button click)
to call `getDisplayMedia`. Calling the user capture
first would prevent the display capture to register
the triggering button click, so this switches the
ordering (for safari only).
Closes elan-ev#934.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@owi92 owi92

Labels
platform:desktop This impacts a desktop version type:bug Something isn't working
Projects
No open projects
Studio Bug Bash
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix safari not capturing both display and camera owi92/opencast-studio
5 participants
@JulianKniephoff @lkiesow @LukasKalbertodt @narickmann @owi92