Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use std::swap #956

Merged
merged 1 commit into from
Sep 26, 2024
Merged

use std::swap #956

merged 1 commit into from
Sep 26, 2024

Conversation

wtholliday
Copy link
Contributor

Just a minor change for code clarity

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.25%. Comparing base (d437097) to head (4f7d355).
Report is 104 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #956      +/-   ##
==========================================
- Coverage   91.84%   88.25%   -3.59%     
==========================================
  Files          37       62      +25     
  Lines        4976     8666    +3690     
  Branches        0     1049    +1049     
==========================================
+ Hits         4570     7648    +3078     
- Misses        406     1018     +612     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pca006132
Copy link
Collaborator

Thanks a lot, but ideally these cleanup PRs can be grouped into one to reduce the number of notification.

Maybe we can wait a bit and see if you still have other cleanup that you can find?

@wtholliday
Copy link
Contributor Author

@pca006132 I'd just merge this one. I'm not sure I'm going to find other small cleanups, this one just jumped out at me

@pca006132 pca006132 merged commit 359274d into elalish:master Sep 26, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants