Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make-manifold #428

Merged
merged 7 commits into from
May 15, 2023
Merged

make-manifold #428

merged 7 commits into from
May 15, 2023

Conversation

elalish
Copy link
Owner

@elalish elalish commented May 9, 2023

Fixes #422

This introduces a tool to upload a GLB and download a manifold GLB with the new extension if it's possible to make the mesh water-tight. I'm running into some OOM problems with certain models, so there are probably some bugs to work out before this can be merged.

@elalish elalish self-assigned this May 9, 2023
@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (58fb7e3) 89.73% compared to head (b28b2ab) 89.74%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #428   +/-   ##
=======================================
  Coverage   89.73%   89.74%           
=======================================
  Files          35       35           
  Lines        4200     4201    +1     
=======================================
+ Hits         3769     3770    +1     
  Misses        431      431           

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@elalish
Copy link
Owner Author

elalish commented May 13, 2023

Okay, there are definitely still some bugs, but this little test pages works reasonable well now. It'll be public at https://manifoldcad.org/make-manifold.html when this is merged. Don't get your hopes up though, most glTFs, even if they look fairly solid, are not actually manifold, nor even close enough for us to merge them automatically.

The worst bug I see now is some complex scenes like the Khronos Buggy and Dragon throw an OOM somewhere in the WASM. I'm guessing this is an error in the Merge function, but we can deal with that in a further PR.

@elalish elalish merged commit f064b2a into master May 15, 2023
@elalish elalish deleted the makeManifold branch May 15, 2023 14:50
@elalish elalish mentioned this pull request Nov 3, 2023
cartesian-theatrics pushed a commit to SovereignShop/manifold that referenced this pull request Mar 11, 2024
* make-manifold working

* prettier

* fixed stack exceeded

* download only manifolds

* keep any meshes that are manifold

* fixed extension accessor writer

* fix read-write roundtrip
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build a manifold extension to glTF
1 participant