Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify the CsgOpNodes as we build them, rather than in GetChildren #368

Merged
merged 15 commits into from
Mar 16, 2023
Merged

Simplify the CsgOpNodes as we build them, rather than in GetChildren #368

merged 15 commits into from
Mar 16, 2023

Commits on Mar 14, 2023

  1. Flatten the CsgOpNodes as we build them, rather than in GetChildren

    @ochafik
    ochafik committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    a43e337 View commit details
    Browse the repository at this point in the history

  2. Don't inline reused nodes in CsgNode::Boolean

    @ochafik
    ochafik committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    f091479 View commit details
    Browse the repository at this point in the history

  3. Reinstate difference -> union rewrite

    @ochafik
    ochafik committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    210bb0e View commit details
    Browse the repository at this point in the history

  4. No need for opportunistic flattening anymore

    @ochafik
    ochafik committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    7b488a5 View commit details
    Browse the repository at this point in the history

  5. Fix typo

    @ochafik
    ochafik committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    166c603 View commit details
    Browse the repository at this point in the history

  6. Remove CsgOpNode::Impl::simplified_

    @ochafik
    ochafik committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    5f91aa9 View commit details
    Browse the repository at this point in the history

  7. Don't overskip referenced nodes in simplification

    @ochafik
    ochafik committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    17a13d6 View commit details
    Browse the repository at this point in the history

  8. Avoid needless copy of shared pointers

    @ochafik
    ochafik committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    3bf059c View commit details
    Browse the repository at this point in the history

  9. Disambiguate CsgOpNode::Impl::flatten_ -> forcedToLeafNodes_ and alig… 

    …n GetChildren arg naming
    @ochafik
    ochafik committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    ce85a44 View commit details
    Browse the repository at this point in the history

  10. Simplified CsgOpNode::GetChildren

    @ochafik
    ochafik committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    147017f View commit details
    Browse the repository at this point in the history

  11. Simpler (a-(b+c)) -> (a-b-c) transform in CsgOpNode::Boolean to work … 

    …better w/ CsgOpNode::ToLeafNode
    @ochafik
    ochafik committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    2ef7d4e View commit details
    Browse the repository at this point in the history

  12. Simpler build hints for large_scene_test.cpp

    @ochafik
    ochafik committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    7cb439c View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2023

  1. [flatten] Refine rules about tree flattening + added test case

    @ochafik
    ochafik committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    409dd3f View commit details
    Browse the repository at this point in the history

  2. [manifold] Propagate transforms when flattening op trees

    @ochafik
    ochafik committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    1adafe8 View commit details
    Browse the repository at this point in the history

  3. [flatten] move tests from manifold_test to boolean_test

    @ochafik
    ochafik committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    6fcf61b View commit details
    Browse the repository at this point in the history