Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prod deployment again #347

Merged
merged 1 commit into from
Mar 1, 2023
Merged

prod deployment again #347

merged 1 commit into from
Mar 1, 2023

Conversation

elalish
Copy link
Owner

@elalish elalish commented Mar 1, 2023

Trying to prod deployment again, a la #345 - hoping this isn't just the definition of insanity...

@elalish elalish self-assigned this Mar 1, 2023
@pca006132
Copy link
Collaborator

I think we can click the 'rerun all jobs' button in the action page. Not sure if it helps with deployment though.

@elalish
Copy link
Owner Author

elalish commented Mar 1, 2023

Yeah, I should try that - I will if this one fails too. The trouble is I'm not sure whether the upload our download step is failing, and they're part of different jobs.

@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change

Comparison is base (2915f7a) 91.52% compared to head (4d9de9c) 91.52%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #347   +/-   ##
=======================================
  Coverage   91.52%   91.52%           
=======================================
  Files          32       32           
  Lines        3730     3730           
=======================================
  Hits         3414     3414           
  Misses        316      316           
Impacted Files Coverage Δ
samples/src/tet_puzzle.cpp 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@elalish elalish merged commit 78c03f2 into master Mar 1, 2023
@elalish elalish deleted the prod2 branch March 1, 2023 06:09
@elalish elalish mentioned this pull request Mar 2, 2023
cartesian-theatrics pushed a commit to SovereignShop/manifold that referenced this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants