Properly encapsulate ES6 type defs. in module

[rafern]

This should fix the weird discrepancy between the type definitions and the actual runtime; doing new Manifold instead of new module.Manifold will now actually show an IDE error.

I'm pretty sure this is correct now, but I'll keep this as a draft so I can take a better look into this tomorrow.

[rafern]

@elalish This should be ready now. I tried to make it work with Monaco, but I can't figure out how; the type definitions are split into multiple files, because we need a public and private version of the Mesh and Manifold classes, but for some reason Monaco doesn't like to cross-reference type definitions. I also can't make it more usable for Monaco by merging the type definitions into a single file, because there is no way to do private type definitions in a .d.ts without multiple files; if I were to use a namespace instead of a separate file, the namespace is auto-exported, meaning you could do, for example, new ManifoldStatic.Manifold, which will result in a runtime error.

Seems like there's 2 choices at the moment:

• Keep using declare as before, for every function and class inside ManifoldStatic. This should make the type definition usable by Monaco, but also allow invalid usage in Typescript (doing new Manifold instead of new module.Manifold, calling cube() instead of module.cube(), etc...). We'd also have to make it work as a module somehow (maybe re-export?)
• (the workaround you added yesterday) Keep this version of the type definitions, but have a separate type definition file for the editor. This is more work, but should give correct type definitions everywhere

I also updated the cmake file to copy the new type definition files to the editor's folder. These aren't being used right now, but it should still be useful if a solution is found in the future.

[codecov]

Codecov Report

Patch and project coverage have no change.

Comparison is base (95daa54) 91.52% compared to head (651729e) 91.52%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #346   +/-   ##
=======================================
  Coverage   91.52%   91.52%           
=======================================
  Files          32       32           
  Lines        3730     3730           
=======================================
  Hits         3414     3414           
  Misses        316      316           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[elalish]

So, do we actually want these? I thought this was what you removed so that new Manifold() would correctly error?

[rafern]

In the way it was done before, both the type and the value were exported. In the new way, Manifold and Mesh are re-exported only as a type (which is why it has export type Manifold instead of export class Manifold), so if you try to do new Manifold you will now get an error. It's only a type AND value when used from a ManifoldStatic instance (which is why it's using Manifold: typeof T.Manifold in ManifoldStatic)

[elalish]

Ah, thank you for the explanation!

[elalish]

Good idea on separating these. I definitely don't want to go back to the declare version. The first priority is getting the types right for npm users - the editor is our own problem. Maybe we could hack it a little though - I'm considering some string concatenation and replacing export with declare during import to the editor.

[rafern]

I'm not sure if that would work, because Typescript really hates bundling type definitions, but it's worth a try. Maybe you could use something like dts-bundle?

[elalish]

Thanks for the help!