Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert manifoldCAD.org to a PWA #336

Merged
merged 3 commits into from
Feb 25, 2023
Merged

Convert manifoldCAD.org to a PWA #336

merged 3 commits into from
Feb 25, 2023

Conversation

elalish
Copy link
Owner

@elalish elalish commented Feb 23, 2023

This should allow us to be installable now.

@elalish elalish self-assigned this Feb 23, 2023
@codecov
Copy link

codecov bot commented Feb 23, 2023

Codecov Report

Base: 91.52% // Head: 91.52% // No change to project coverage 👍

Coverage data is based on head (7302775) compared to base (32f887d).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #336   +/-   ##
=======================================
  Coverage   91.52%   91.52%           
=======================================
  Files          32       32           
  Lines        3730     3730           
=======================================
  Hits         3414     3414           
  Misses        316      316           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@elalish
Copy link
Owner Author

elalish commented Feb 23, 2023

Oh, actually it needs a service worker too, stay tuned.

@elalish elalish merged commit feb7fb6 into master Feb 25, 2023
@elalish elalish deleted the pwa branch February 25, 2023 17:49
cartesian-theatrics pushed a commit to SovereignShop/manifold that referenced this pull request Mar 11, 2024
* added PWA manifest

* added service worker

* check for service worker
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant