Added missing JS bindings (from discussion in #317) #320
Conversation
|
All done, let me know if you have any more changes. The C++ is already changed and it doesn't throw any compile errors, but I haven't done any testing with real code. I'll probably port gypsum this weekend, but if you want to merge it now that's OK too, and I can test later |
|
@rafern So, our CI only runs on non-draft PRs, so I marked yours as ready for review, but Github has a bug where it caches the stale value of "draft" and so still won't run the CI. Can you push some trivial commit to prod it into action? |
|
@elalish Should be good now |
|
Yeah, working on it. I forgot that there were other bindings that needed to be updated. I'll ping you once it's done |
|
@elalish Done. I haven't updated the Python bindings though, since I'm not familiar with how that works, but it should be fine for now since there aren't any tests |
Codecov ReportBase: 91.50% // Head: 91.50% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #320 +/- ##
=======================================
Coverage 91.50% 91.50%
=======================================
Files 32 32
Lines 3722 3722
=======================================
Hits 3406 3406
Misses 316 316
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
@elalish I was supposed to do this 3 weekends ago (sorry), but I just wanted to let you know that I finally ported gypsum to the newer version of Manifold, and got to test the WASM bindings. Everything seems to work fine, and normals get transformed as expected: Tangents need to be transformed manually, but that's OK because there's the Thanks for your work on the new API! |
|
@rafern Excellent, great to know it's working! Would you be interested in adding gypsum to our list of users? Also, considering the recent addition of |
|
@elalish Yeah, sure, I'll add to the list of users. I can work on the bindings, but I won't make any promises on a timeline as those haven't gone very well so far 😅 |
* Added missing JS bindings (from discussion in elalish#317) * Fix formatting * Add reserveIDs JS bindings * Use numRun instead of numMatrix * Make numProp, triVerts and vertProperties required options in Mesh ctor. * Rename MeshJS originalID to runOriginalID, and transform to runTransform * Fix formatting with clang-format * Trigger CI * Added missing C bindings * Rename matrix to transform in JS type definitions * Rename numMatrix to numRun in JS type defs almost forgot this one again * JS bindings, transform index -> run
matrix. I feel like this is a bad name, any suggestions?Marking this as a draft since I haven't had the time to test this yet. Will update this PR once I port gypsum and test it with the new API.