Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove manifold_meshgl_vert_normal from header (impl gone) #310

Merged
merged 1 commit into from
Jan 26, 2023
Merged

Remove manifold_meshgl_vert_normal from header (impl gone) #310

merged 1 commit into from
Jan 26, 2023

Conversation

geoffder
Copy link
Collaborator

Caught a straggling ghost function in the header when updating my bindings.

@codecov-commenter
Copy link

Codecov Report

Base: 91.54% // Head: 91.54% // No change to project coverage 👍

Coverage data is based on head (6741c64) compared to base (422c7f2).
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #310   +/-   ##
=======================================
  Coverage   91.54%   91.54%           
=======================================
  Files          33       33           
  Lines        3608     3608           
=======================================
  Hits         3303     3303           
  Misses        305      305           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Owner

@elalish elalish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@elalish elalish merged commit 05f9ceb into elalish:master Jan 26, 2023
cartesian-theatrics pushed a commit to SovereignShop/manifold that referenced this pull request Mar 11, 2024
Remove meshgl_vert_normal from header (impl gone)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants