Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use compose for disjoint union #217

Merged
merged 3 commits into from
Sep 25, 2022
Merged

Commits on Sep 25, 2022

  1. use compose for disjoint union

    Last mystery in elalish#114. It turns out that the problem is due to
    misunderstanding of the bounding box API: Box::Transform is *not* a safe
    over-approximation of the bounding box of the manifold after the
    transform. In fact it might be smaller than that if the transform is not
    axis aligned. The simple fix is to apply the transform first and then
    compute the bounding box, this will also make sure that the bounding box
    is tight.
    pca006132 committed Sep 25, 2022
    Configuration menu
    Copy the full SHA
    05aae7e View commit details
    Browse the repository at this point in the history
  2. fix batch union

    pca006132 committed Sep 25, 2022
    Configuration menu
    Copy the full SHA
    8dcab8b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8c7995f View commit details
    Browse the repository at this point in the history