Skip to content

Commit

Permalink
iox-eclipse-iceoryx#2011 Remove GCC 5.4 from CI and document GCC 8.3 …
Browse files Browse the repository at this point in the history
…as minimal version
  • Loading branch information
elBoberido committed Sep 7, 2023
1 parent 1c19704 commit 123bc62
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 68 deletions.
11 changes: 1 addition & 10 deletions .github/workflows/build-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ jobs:
- uses: actions/checkout@v3
- uses: egor-tensin/setup-gcc@v1.3
with:
# gcc 8.3 is compiler used in QNX 7.1
version: 8
platform: x64
- uses: jwlawson/actions-setup-cmake@v1.13
Expand Down Expand Up @@ -132,16 +133,6 @@ jobs:
- name: Run Thread Sanitizer
run: ./tools/ci/build-test-ubuntu-with-sanitizers.sh clang tsan

# gcc 5.4 is compiler used in QNX 7.0
build-test-ubuntu-with-gcc5:
# prevent stuck jobs consuming runners for 6 hours
timeout-minutes: 60
runs-on: ubuntu-latest
needs: pre-flight-check
steps:
- uses: actions/checkout@v3
- run: ./tools/ci/build-test-ubuntu-with-gcc5.sh

# Bazel sanity check
build-test-ubuntu-bazel:
# prevent stuck jobs consuming runners for 6 hours
Expand Down
8 changes: 4 additions & 4 deletions doc/website/getting-started/installation.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ All iceoryx libraries are deployed as independent CMake packages. Posh is using
- 64-bit hardware (e.g. x86_64 or aarch64; 32-bit hardware might work, but is not supported)
- [CMake](https://cmake.org), 3.16 or later
- One of the following compilers:
- [GCC](https://gcc.gnu.org), 8.3 or later (5.4 currently supported too)
- [GCC](https://gcc.gnu.org), 8.3 or later
- [Clang](https://clang.llvm.org), 9.0 or later
- [MSVC](https://visualstudio.microsoft.com/de/), part of Visual Studio 2019 or later
- [libacl](http://download.savannah.gnu.org/releases/acl/), 2.2 or later. Only for Linux & QNX.
Expand All @@ -35,7 +35,7 @@ make install

### Linux

Although we strive to be fully POSIX-compliant, we recommend using Ubuntu 18.04 and at least GCC 7.5.0 for development.
Although we strive to be fully POSIX-compliant, we recommend using Ubuntu 20.04 and at least GCC 8.3 for development.

You will need to install the following packages:

Expand All @@ -47,7 +47,7 @@ Additionally, there is an optional dependency to the [cpptoml](https://github.co

### QNX

QNX SDP 7.0 and 7.1 are supported (shipping with gcc 5.4 and gcc 8.3 respectively).
QNX SDP 7.1 is supported (shipping with gcc 8.3 respectively).

The easiest way to build iceoryx on QNX is by using the build script and providing a toolchain file.
We provide generic QNX SDP 7.0 toolchain files for ARM_64 and X86_64 in `./tools/toolchains/qnx` ([Direct Link](../../../tools/toolchains/qnx)).
Expand Down Expand Up @@ -118,7 +118,7 @@ The `CMakeLists.txt` from `iceoryx_meta` can be used to easily develop iceoryx w
```

If the compilation fails, it is possible that the compilation failure originates
inside the Windows SDK and is not caused by iceoryx, see
inside the Windows SDK and is not caused by iceoryx, see
[Windows vcpkg-issue \#15035](https://github.com/microsoft/vcpkg/issues/15035#issuecomment-742427969.)
In this case try to rebuild the cmake files with:
```bash
Expand Down
4 changes: 4 additions & 0 deletions doc/website/release-notes/iceoryx-unreleased.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@

[Full Changelog](https://github.com/eclipse-iceoryx/iceoryx/compare/vx.x.x...vx.x.x) <!--NOLINT remove this when tag is set-->

**Notes**

- The minimal supported GCC compiler is now 8.3

**Features:**

- Add bazel asan, usan, tsan build config [#1547](https://github.com/eclipse-iceoryx/iceoryx/issues/1547)
Expand Down
54 changes: 0 additions & 54 deletions tools/ci/build-test-ubuntu-with-gcc5.sh

This file was deleted.

0 comments on commit 123bc62

Please sign in to comment.