Skip to content

Commit

Permalink
Warning when NoSync setting is set as it is does not turn syncing off i…
Browse files Browse the repository at this point in the history
…pfs#3799

License: MIT
Signed-off-by: Esteban Ginez <eginez@gmail.com>
  • Loading branch information
eginez committed May 28, 2018
1 parent 2ba7179 commit bc1a0d8
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions repo/fsrepo/fsrepo.go
Original file line number Diff line number Diff line change
Expand Up @@ -400,6 +400,9 @@ func (r *FSRepo) openDatastore() error {
} else if r.config.Datastore.Spec == nil {
return fmt.Errorf("required Datastore.Spec entry missing from config file")
}
if r.config.Datastore.NoSync {
log.Warning("NoSync is now deprecated in favor of datastore specific settings. If you want to disable fsync on flatfs set 'sync' to false'. See https://github.com/ipfs/go-ipfs/blob/master/docs/datastores.md#flatfs.")
}

dsc, err := AnyDatastoreConfig(r.config.Datastore.Spec)
if err != nil {
Expand Down

0 comments on commit bc1a0d8

Please sign in to comment.