Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This issue to track ABI/API changes for next major eggdrop version #1491

Open
michaelortmann opened this issue Oct 16, 2023 · 1 comment
Open

Comments

@michaelortmann
Copy link
Member

michaelortmann commented Oct 16, 2023

eggdrop/src/eggdrop.h

Lines 346 to 347 in 322bddb

long sock; /* This should be a long to keep 64-bit machines sane. */
/* ^-- Disagreed with, but changing back to int would break ABI */

type should be uint16_t for:

unsigned int port;

@michaelortmann
Copy link
Member Author

Remove misc.c:oatoi().
Use strtol() instead
Currently there is only one usage in eggdrop, and PR #1551 would remove that.
This function should have never been exported via module API. "Maybe someone could find it useful" is a bad reason to bloat a module API. Please lets not do this again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant