feat: Create a common Address struct for V2 API #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weichou1229
force-pushed
the
issue-523
branch
from
848809c
to
83b94a3
Compare
weichou1229
force-pushed
the
issue-523
branch
from
83b94a3
to
dce0f45
Compare
lenny-goodell
requested changes
Mar 1, 2021
|
from @tonyespy : let’s name it Address, so as not to confuse it with the old addressable object. |
cloudxxx8
changed the title
Create a common Addressable struct for different endpoint protocols Signed-off-by: weichou <weichou1229@gmail.com>
Rename and add fields Signed-off-by: weichou <weichou1229@gmail.com>
- Rename Addressable to Address - Remove BaseAddress DTO because the json unmarshal func can't identify repeat fields - Add test for json unmarshalling and validation Close edgexfoundry#523 Signed-off-by: weichou <weichou1229@gmail.com>
|
I did the following changes, please help review.
|
cloudxxx8
requested changes
Mar 7, 2021
|
Renamed MqttPubAddress to MQTTPubAddress. |
Fix edgexfoundry#523 Signed-off-by: weichou <weichou1229@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #525 +/- ##
==========================================
- Coverage 56.59% 55.98% -0.61%
==========================================
Files 119 120 +1
Lines 3564 3626 +62
==========================================
+ Hits 2017 2030 +13
- Misses 1357 1405 +48
- Partials 190 191 +1
Continue to review full report at Codecov.
|
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-core-contracts/blob/master/.github/Contributing.md.
What is the current behavior?
Issue Number: #523
What is the new behavior?
Create a common Addressable struct for different endpoint protocols
Does this PR introduce a breaking change?
New Imports
Specific Instructions
Are there any specific instructions or things that should be known prior to reviewing?
Other information