refactor: Rework entry point scripts to run 'listenTcp' command as non-root #3292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jim-wang-intel
requested changes
Mar 24, 2021
cmd/security-bootstrapper/entrypoint-scripts/consul_wait_install.sh
Outdated
Show resolved
Hide resolved
cmd/security-bootstrapper/entrypoint-scripts/consul_wait_install.sh
Outdated
Show resolved
Hide resolved
added 2 commits
March 24, 2021 08:44
…n-root closes edgexfoundry#3221 Signed-off-by: lenny <leonard.goodell@intel.com>
Signed-off-by: lenny <leonard.goodell@intel.com>
lenny-goodell
force-pushed
the
run-as-non-root
branch
from
5c807f8
to
aec761c
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #3292 +/- ##
=======================================
Coverage 42.53% 42.53%
=======================================
Files 183 183
Lines 15838 15838
=======================================
Hits 6737 6737
Misses 8663 8663
Partials 438 438 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/master/.github/Contributing.md.
What is the current behavior?
'listenTcp' command runs as root everywhere it is used.
Issue Number: #3221
What is the new behavior?
'listenTcp' command now runs as non-root everywhere it is used.
Does this PR introduce a breaking change?
New Imports
Specific Instructions
Are there any specific instructions or things that should be known prior to reviewing?
Other information