Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Update remaining SecretService references to be SecretStore #3189

Merged
merged 1 commit into from
Feb 23, 2021

Conversation

lenny-goodell
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/master/.github/Contributing.md.

What is the current behavior?

The following still refer to SecretService which has ben changed to SecretStore for Secret Store Setup & Proxy Setup

  • Snap env overrides
  • Secret Store Setup README
  • Proxy Setup testdata config

Issue Number: #3188

What is the new behavior?

The following now refer to new SecretStore for Secret Store Setup & Proxy Setup

  • Snap env overrides
  • Secret Store Setup README
  • Proxy Setup testdata config

Does this PR introduce a breaking change?

  • Yes
  • No
    Previous PR contained the breaking change

New Imports

  • Yes
  • No

Specific Instructions

Are there any specific instructions or things that should be known prior to reviewing?

Other information

- Snap env overrides
- Secret Store Setup README
- Proxy Setup testdata config

close edgexfoundry#3188

Signed-off-by: lenny <leonard.goodell@intel.com>
@sonarcloud
Copy link

sonarcloud bot commented Feb 23, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@jim-wang-intel jim-wang-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenny-goodell lenny-goodell merged commit afdb9f2 into edgexfoundry:master Feb 23, 2021
@lenny-goodell lenny-goodell deleted the snap-secret-store branch February 23, 2021 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants