feat(security): Remove Writable from security services #3147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jim-wang-intel
requested review from
beaufrusetta,
hutchic,
jpwhitemn,
bnevis-i and
lenny-goodell
lenny-goodell
requested changes
Feb 8, 2021
| LogLevel = "DEBUG" | ||
|
|
||
| [ProxySetup] |
There was a problem hiding this comment.
no particular strong reason, i just felt that it can be more structural in this way since potentially you can have many more RequestTimout for that naming alone.
There was a problem hiding this comment.
It is redundant since this is Proxy Setup's specific configuration. IMO, the extra level isn't needed. We added the extra levels in the bootstrapper config to make the Env override more readable, but that isn't needed here.
jim-wang-intel
force-pushed
the
remove-writable-for-sec-srvs
branch
from
15c04cc
to
377e5e1
Compare
Update for security services on: - Loglevel is on the top level of ConfigurationStruct - Remove Writable from Configuration struct - Make UpdateFromRaw, UpdateWritableFromRaw do nothing and make EmptyWritablePtr just return nil Fixes: edgexfoundry#3123 Signed-off-by: Jim Wang <yutsung.jim.wang@intel.com>
jim-wang-intel
force-pushed
the
remove-writable-for-sec-srvs
branch
from
1328e27
to
266ed88
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
lenny-goodell
approved these changes
Feb 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update for security services on:
Fixes: #3123
Signed-off-by: Jim Wang yutsung.jim.wang@intel.com
PR Checklist
Please check if your PR fulfills the following requirements:
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/master/.github/Contributing.md.
What is the current behavior?
security services have Writable struct but actually it never uses
Issue Number: #3123
What is the new behavior?
Refactor the
LogLevelinside Writable struct and remove Writable.Does this PR introduce a breaking change?
New Imports
Specific Instructions
Are there any specific instructions or things that should be known prior to reviewing?
Depends on PR #2863 as the redis' toml conf would also be removed about the Writable section.
Other information