feat: Remove MetadataCheck mechanism when adding Event #3069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Decided in the Core WG meeting on Jan-21 2021. Remove MetadataCheck mechanism when adding Event for now. Close #3062 Signed-off-by: weichou <weichou1229@gmail.com>
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #3069 +/- ##
==========================================
- Coverage 40.71% 40.71% -0.01%
==========================================
Files 168 167 -1
Lines 14090 14080 -10
==========================================
- Hits 5737 5732 -5
+ Misses 8026 8022 -4
+ Partials 327 326 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decided in the Core WG meeting on Jan-21 2021. Remove MetadataCheck mechanism when adding Event for now.
Close #3062
PR Checklist
Please check if your PR fulfills the following requirements:
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/master/.github/Contributing.md.
What is the current behavior?
Event POST API checks whether the device is exist when the config MetaDataCheck is true
Issue Number: #3062
What is the new behavior?
Remove the MetaDataCheck from the API.
Does this PR introduce a breaking change?
New Imports
Specific Instructions
Are there any specific instructions or things that should be known prior to reviewing?
Other information