fix(meta): Delete DS API should check the associated Device existence #3054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Delete Device Service API should check the associated Device existence. If there is any associated Device exists, the Device Service deletion should return error. fix 2989 Signed-off-by: weichou <weichou1229@gmail.com>
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #3054 +/- ##
=======================================
Coverage 40.28% 40.28%
=======================================
Files 158 158
Lines 13736 13736
=======================================
Hits 5533 5533
Misses 7882 7882
Partials 321 321 Continue to review full report at Codecov.
|
lenny-goodell
approved these changes
Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix 2989
PR Checklist
Please check if your PR fulfills the following requirements:
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/master/.github/Contributing.md.
What is the current behavior?
Delete Device Service API doesn't check the associated Device existence.
Issue Number: #2989
What is the new behavior?
Delete Device Service API should check the associated Device existence.
If there is any associated Device exists, the Device Service deletion should return error.
Does this PR introduce a breaking change?
New Imports
Specific Instructions
Are there any specific instructions or things that should be known prior to reviewing?
Other information