Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove deprecated Mongo code. #2956

Merged
merged 1 commit into from
Dec 16, 2020

Conversation

lenny-goodell
Copy link
Member

@lenny-goodell lenny-goodell commented Dec 16, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/master/.github/Contributing.md.

What is the current behavior?

Deprecated Mongo code exists, so Mongo is still a feature

Issue Number: #2598

What is the new behavior?

Mongo code has been remove. Mongo DB is no longer a feature.

Does this PR introduce a breaking change?

  • Yes
  • No

New Imports

  • Yes
  • No

Specific Instructions

Are there any specific instructions or things that should be known prior to reviewing?

Other information

README.md Outdated Show resolved Hide resolved
Mongo DB is no longer a feature.

closes edgexfoundry#2598

Signed-off-by: Lenny Goodell <leonard.goodell@intel.com>
@sonarcloud
Copy link

sonarcloud bot commented Dec 16, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-io
Copy link

Codecov Report

Merging #2956 (eb06a9b) into master (1cb9438) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2956      +/-   ##
==========================================
- Coverage   40.70%   40.69%   -0.01%     
==========================================
  Files         170      169       -1     
  Lines       14113    14104       -9     
==========================================
- Hits         5745     5740       -5     
+ Misses       7991     7988       -3     
+ Partials      377      376       -1     
Impacted Files Coverage Δ
internal/security/secretstore/init.go 3.84% <ø> (ø)
internal/core/data/v2/application/event.go 67.59% <0.00%> (+3.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cb9438...eb06a9b. Read the comment docs.

Copy link
Contributor

@jim-wang-intel jim-wang-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenny-goodell lenny-goodell merged commit dd265b0 into edgexfoundry:master Dec 16, 2020
@lenny-goodell lenny-goodell deleted the remove-mongo branch December 16, 2020 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Mongo DB implementation code
3 participants