feat: create optional kong certificate config options #2940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jim-wang-intel
added
enhancement
lenny-goodell
requested changes
Dec 11, 2020
|
@beaufrusetta , please rebase |
Rebase complete. |
Codecov Report
@@ Coverage Diff @@
## master #2940 +/- ##
==========================================
- Coverage 40.66% 40.64% -0.03%
==========================================
Files 170 170
Lines 14156 14163 +7
==========================================
Hits 5756 5756
- Misses 8023 8030 +7
Partials 377 377
Continue to review full report at Codecov.
|
The kong config options for CertPath, CertFilePath, and KeyFilePath in configuration.toml are now optional. By default, those values are now empty. I also cleaned up a single quote situation in the token provider configuration.toml. fixes: #2928 Signed-off-by: Beau Frusetta <beau.frusetta@intel.com>
|
Kudos, SonarCloud Quality Gate passed!
|
|
Please see latest update - trimmed concatenated config values. @lenny-intel @jim-wang-intel @bnevis-i |
lenny-goodell
approved these changes
Dec 11, 2020
bnevis-i
approved these changes
Dec 11, 2020
jim-wang-intel
pushed a commit
to jim-wang-intel/edgex-go
that referenced
this pull request
Dec 15, 2020
The kong config options for CertPath, CertFilePath, and KeyFilePath in configuration.toml are now optional. By default, those values are now empty. I also cleaned up a single quote situation in the token provider configuration.toml. fixes: edgexfoundry#2928 Signed-off-by: Beau Frusetta <beau.frusetta@intel.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/master/.github/Contributing.md.
What is the current behavior?
Values for CertPath, CertFilePath, and KeyFilePath are required in the configuration.toml.
Issue Number:
#2928
What is the new behavior?
The kong config options for CertPath, CertFilePath, and KeyFilePath
in configuration.toml are now optional. By default, those values
are now empty. I also cleaned up a single quote situation in the
token provider configuration.toml.
Does this PR introduce a breaking change?
New Imports
Specific Instructions
Are there any specific instructions or things that should be known prior to reviewing?
Other information