refactor(all): Remove support-logging and LoggingInfo config #2919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpwhitemn
previously approved these changes
Dec 3, 2020
closes edgexfoundry#2599 Signed-off-by: lenny <leonard.goodell@intel.com>
lenny-goodell
force-pushed
the
remove-support-logging
branch
from
69f2236
to
0f7cd34
Compare
Signed-off-by: lenny <leonard.goodell@intel.com>
|
recheck |
Signed-off-by: lenny <leonard.goodell@intel.com>
lenny-goodell
force-pushed
the
remove-support-logging
branch
from
0f7cd34
to
fc0a0c9
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
jpwhitemn
approved these changes
Dec 3, 2020
jim-wang-intel
pushed a commit
to jim-wang-intel/edgex-go
that referenced
this pull request
Dec 15, 2020
…undry#2919) * refactor(all): Remove support-logging and LoggingInfo config closes edgexfoundry#2599
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/master/.github/Contributing.md.
What is the current behavior?
Support Logging service exists and all services have LoggingInfo configuration
Issue Number: #2599
What is the new behavior?
Support Logging service has been removed and all service's LoggingInfo configuration has been removed
Does this PR introduce a breaking change?
New Imports
Specific Instructions
Are there any specific instructions or things that should be known prior to reviewing?
Other information