Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core-data): Error handling for V2 API #2681

Merged
merged 1 commit into from
Sep 15, 2020

Conversation

cloudxxx8
Copy link
Member

@cloudxxx8 cloudxxx8 commented Sep 7, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit subject follows the Conventional Commits spec
  • The commit message follows the EdgeX Contributor Guide
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • make test has completed successfully

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

What is the new behavior?

Modify V2 core-data implementation to adopt the new feature in edgexfoundry/go-mod-core-contracts#279

Issue Number: Fix #1734

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any new imports or modules? If so, what are they used for and why?

Are there any specific instructions or things that should be known prior to reviewing?

Other information

@cloudxxx8 cloudxxx8 added the hold Intended for PRs we want to flag for ongoing review label Sep 7, 2020
@cloudxxx8
Copy link
Member Author

This PR needs to wait until edgexfoundry/go-mod-core-contracts#279 merged

@cloudxxx8 cloudxxx8 force-pushed the issue-1734 branch 2 times, most recently from c6c1fc8 to 5628b0a Compare September 12, 2020 14:34
@cloudxxx8 cloudxxx8 removed the hold Intended for PRs we want to flag for ongoing review label Sep 12, 2020
@cloudxxx8 cloudxxx8 marked this pull request as ready for review September 12, 2020 14:37
lenny-goodell
lenny-goodell previously approved these changes Sep 15, 2020
Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudxxx8
Copy link
Member Author

recheck

Modify V2 core-data implementation to adopt the new feature in edgexfoundry/go-mod-core-contracts#279

Fix edgexfoundry#1734

Signed-off-by: Cloud Tsai <cloudxxx8@gmail.com>
@cloudxxx8
Copy link
Member Author

rebased

@sonarcloud
Copy link

sonarcloud bot commented Sep 15, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenny-goodell lenny-goodell merged commit 79f01a0 into edgexfoundry:master Sep 15, 2020
@cloudxxx8 cloudxxx8 deleted the issue-1734 branch September 15, 2020 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error Handling Refactor
2 participants