-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(core-data): Error handling for V2 API #2681
Conversation
This PR needs to wait until edgexfoundry/go-mod-core-contracts#279 merged |
c6c1fc8
to
5628b0a
Compare
5628b0a
to
24959f7
Compare
24959f7
to
bd2279e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
recheck |
Modify V2 core-data implementation to adopt the new feature in edgexfoundry/go-mod-core-contracts#279 Fix edgexfoundry#1734 Signed-off-by: Cloud Tsai <cloudxxx8@gmail.com>
bd2279e
to
031dcb6
Compare
rebased |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR Checklist
Please check if your PR fulfills the following requirements:
make test
has completed successfullyPR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
Modify V2 core-data implementation to adopt the new feature in edgexfoundry/go-mod-core-contracts#279
Issue Number: Fix #1734
Does this PR introduce a breaking change?
Are there any new imports or modules? If so, what are they used for and why?
Are there any specific instructions or things that should be known prior to reviewing?
Other information