Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't use hostname for webserver ListenAndServe #2579

Merged
merged 1 commit into from
Jun 2, 2020

Conversation

lenny-goodell
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit subject follows the Conventional Commits spec
  • The commit message follows the EdgeX Contributor Guide
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • make test has completed successfully

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

ListenAndServe was lock to specific adapter for the specified hostname

Issue Number: #2578

What is the new behavior?

ListenAndServe now not using hostname so available on any of the host system's adapters

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any specific instructions or things that should be known prior to reviewing?

Other information

closes edgexfoundry#2578

Signed-off-by: lenny <leonard.goodell@intel.com>
@sonarcloud
Copy link

sonarcloud bot commented Jun 2, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@rsdmike
Copy link
Member

rsdmike commented Jun 2, 2020

Will keep an eye out for restrictions on ipv4 vs ipv6 due to 0.0.0.0 value instead of blank.

@lenny-goodell
Copy link
Member Author

recheck

@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2020

Codecov Report

Merging #2579 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2579      +/-   ##
==========================================
- Coverage   38.84%   38.81%   -0.04%     
==========================================
  Files         150      145       -5     
  Lines       13075    12722     -353     
==========================================
- Hits         5079     4938     -141     
+ Misses       7690     7510     -180     
+ Partials      306      274      -32     
Impacted Files Coverage Δ
internal/security/secretstore/init.go 3.92% <0.00%> (-3.27%) ⬇️
internal/security/pipedhexreader/mocks/mock.go
internal/security/secretstore/vmkencryption.go
internal/security/kdf/methods.go
internal/security/kdf/mocks/mock.go
internal/security/pipedhexreader/pipedhexreader.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c805690...cda5488. Read the comment docs.

@lenny-goodell lenny-goodell merged commit 525c654 into edgexfoundry:master Jun 2, 2020
@lenny-goodell lenny-goodell deleted the webserver branch June 2, 2020 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants